Skip to content

[build] Remove FILES_MATCHING from SwiftShims/CMakeLists.txt #34241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Oct 8, 2020

This is not an ideal solution, as we are likely installing more that we
should with those instructions -- but it would unblock quickly the
Source Compatibility suite.

Addresses rdar://70040046

This is not an ideal solution, as we are likely installing more that we
should with those instructions -- but it would unblock quickly the
Source Compatibility suite.

Addresses rdar://70040046
@edymtt
Copy link
Contributor Author

edymtt commented Oct 8, 2020

@swift-ci please smoke test

@edymtt
Copy link
Contributor Author

edymtt commented Oct 8, 2020

@swift-ci Please Test Source Compatibility Debug

@porglezomp
Copy link
Contributor

What files were getting omitted with these? I did a quick check and didn't notice non- .h files while I was prepping this, but I clearly missed something.

@edymtt
Copy link
Contributor Author

edymtt commented Oct 9, 2020

The compiler-rt libraries under usr/lib/swift/clang when installing content in the intermediate-install folder

@edymtt
Copy link
Contributor Author

edymtt commented Oct 9, 2020

@swift-ci please smoke test Linux

@edymtt edymtt merged commit a482c9c into swiftlang:main Oct 9, 2020
@edymtt edymtt deleted the restore_old_pattern_swiftshims branch October 9, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants