Skip to content

[Gardening] Migrate complete_expr_postfix_begin test to use new batching #34570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

bnbarham
Copy link
Contributor

@bnbarham bnbarham commented Nov 4, 2020

I changed this test in my other PR. Figured it would be good to migrate it over to the new batch mode while I was there.

@bnbarham bnbarham requested a review from rintaro November 4, 2020 02:06
@bnbarham
Copy link
Contributor Author

bnbarham commented Nov 4, 2020

@swift-ci please test

@bnbarham bnbarham force-pushed the migrate-postfix-begin-test branch from b2fdec4 to 23d0829 Compare November 4, 2020 03:20
@swift-ci
Copy link
Contributor

swift-ci commented Nov 4, 2020

Build failed
Swift Test OS X Platform
Git Sha - b2fdec43350b78cf119b24c4cb640f4e97a24039

@bnbarham
Copy link
Contributor Author

bnbarham commented Nov 4, 2020

@swift-ci please smoke test

@bnbarham
Copy link
Contributor Author

bnbarham commented Nov 4, 2020

I'd be more comfortable with a full test but OSX is failing on main at the moment :(

@bnbarham
Copy link
Contributor Author

bnbarham commented Nov 4, 2020

@swift-ci please smoke test

Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bnbarham
Copy link
Contributor Author

bnbarham commented Nov 5, 2020

I'll wait until yours is merged and then change this one to use the new XFAIL instead

@bnbarham bnbarham force-pushed the migrate-postfix-begin-test branch from 23d0829 to b4572c4 Compare November 5, 2020 03:27
@bnbarham
Copy link
Contributor Author

bnbarham commented Nov 5, 2020

@swift-ci please smoke test

@bnbarham bnbarham merged commit 5b74552 into swiftlang:main Nov 5, 2020
@bnbarham bnbarham deleted the migrate-postfix-begin-test branch November 5, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants