Fix LoadBorrowImmutabilityChecker for partial applies #34658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gottesmm thanks for the suggestions for the fix. I am currently allowing any in_guaranteed address passed to a partial_apply onstack/ or not to not be considered as a write. What do you think ? |
meg-gupta
force-pushed
the
fixloadborrowpa
branch
2 times, most recently
from
29e071d to
c1a5337
Compare
meg-gupta
force-pushed
the
fixloadborrowpa
branch
from
c1a5337 to
68da472
Compare
|
@swift-ci smoke test |
|
@meg-gupta I think this is incorrect. Its only onstack where this is true. |
|
Fixed here - #34736 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not mark addresses passed as in_guaranteed parameters to a partial apply as a write in the LoadBorrowImmutabilityChecker
Fixes rdar://70687511