Allow a borrowed address to be passed as in_guaranteed arg in partial_apply [on_stack] only #34736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
gottesmm
reviewed
Nov 13, 2020
| @@ -25,18 +25,6 @@ bb0(%0 : $*WrapperStruct): | |||
| return %res : $() | |||
| } | |||
|
|
|||
| sil [ossa] @test2 : $@convention(thin) (@in_guaranteed WrapperStruct) -> () { | |||
| bb0(%0 : $*WrapperStruct): | |||
| %1 = load_borrow %0 : $*WrapperStruct | |||
There was a problem hiding this comment.
Can you add a positive test that checks that we fail.
…l_apply [on_stack] only
meg-gupta
force-pushed
the
fixpaborrow
branch
from
6c73eda to
6f46d42
Compare
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
ainu-bot
added a commit
to google/swift
that referenced
this pull request
Nov 16, 2020
* 'main' of github.com:apple/swift: (89 commits) Fix SILVerifier assert for witness_method with dynamic self type (swiftlang#34738) Allow a borrowed address to be passed as in_guaranteed arg in partial_apply [on_stack] only (swiftlang#34736) Fix test for windows/linux IRGen: Fix debug emission for dynamically sized stack vars [Testing] Add missing REQUIRES: concurrency [ownership] Make SILUndef always have ValueOwnershipKind::None. [value-lifetime] Cleanup constructors. [ownership] Centralize the concept of isReborrow on BorrowingOperand. [sil][value-lifetime] Add ValueLifetimeAnalysis::FrontierImpl = SmallVectorImpl<SILInstruction *> [Test] Disable partial_apply_forwarder.sil for arm64e. [Async CC] Unroll workaround where @main was async. Remove test that depends on Swift.Int metadata, which isn't around. [Concurrency] More cleanups for futures [Concurrency] Remove an unnecessary 'const' from a non-static data member. [Concurrency] Minor cleanups to futures. [Concurrency] Have future functions write their results directly. [Concurrency] Clarify/fix error object handling in futures. [Concurrency] Inline AsyncTask::FutureFragment::fragmentSize. [Concurrency] Turn "simple task" into just "task". [Concurrency] Use SchedulerPrivate for the "next waiting task" link. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.