-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[ConstraintSystem] Infer some of the bindings attributes on demand #34737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e is not longer necessary Since closure body isn't opened until its contextual type is resolved there is no need to explicitly delay attempting bindings for closure parameter used in the body anymore.
@swift-ci please test |
@swift-ci please test source compatibility |
Build failed |
@swift-ci please test Linux platform |
Build failed |
Investigating! Thanks. |
Build failed |
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
One step closer to being able to make potential binding inference incremental.
Let's make most of the flags in
PotentialBindings
be computed on demand basedon information captured in the bindings, including:
IsHole
- could be determined based on a presence of a single binding to a hole type;NumDefaultableBindings
- just a number of bindings originated in defaultable constraint;IsPotentiallyIncomplete
- determined based on bindings and locator;SubtypeOfExistentialType
- determined based on recorded bindings;Most of the flags here are only used for ranking and recorded in a
BindingScore
so don't have to be re-computed multiple times.