Add a field reflection function that constructs keypaths. #34815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the existing _forEachField in ReflectionMirror.swift already gives the offsets and types for each field, this isn't enough information to construct a keypath for that field in order to modify it. For reference, this should be sufficent to implement the features described here: (https://forums.swift.org/t/storedpropertyiterable/19218/62) purely at runtime without any derived conformances for many types. Note: Since there isn't enough reflection information for `.mutatingGetSet` fields, this means that we're not able to support reflecting certain types of fields (functions, nonfinal class fields, etc). Whether this is an error or not is controlled by the `.ignoreUnknown` option.
pschuh
force-pushed
the
keypath-reflect
branch
from
a355701 to
d8472bb
Compare
|
@swift-ci please test |
ainu-bot
pushed a commit
to google/swift
that referenced
this pull request
Dec 1, 2020
* 'main' of github.com:apple/swift: (67 commits) [build-script] Allow to tune dsymutil parallelism (swiftlang#34795) [Testing] Add missing REQUIRES [concurrency] SILGen: emit @asyncHandler functions. [concurrency] SILGen: allow the Builtin.createAsyncTaskFuture to have a non-generic closure argument. [concurrency] stdlib: add a _runAsyncHandler compiler intrinsic. Mangling: add support for mangling the body-function of asyncHandlers Make sure ~AutoDiffLinearMapContext() is called. fix SourceLoc-related crasher and add tests [AutoDiff] Bump-pointer allocate pullback structs in loops. (swiftlang#34886) update differentiable programming manifesto [Async CC] Always add full type metadata to bindings. [cxx-interop] Fix assertion to allow variadic members. [ome] Remove bad pattern of having a global SILBuilder with a global SILBuilderWithContext and multiple local SILBuilderWithScope. [ome] Invoke simplifyInstruction after lowering ownership and use replaceAllSimplifiedUsesAndErase instead of a manual RAUW. Partially revert Float16 availability changes (swiftlang#34847) Add a field reflection function that constructs keypaths. (swiftlang#34815) Allow the creation of a shadow variable when the type is a refcounted pointer (swiftlang#34835) [CMake] Extend copy-legacy-layouts dependency to swiftmodules (swiftlang#34846) [sil] Remove usage from TypeLowering of SILBuilder::create*AndFold(). [allocbox-to-stack] Fix an ossa bug in PromotedParamCloner. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the existing _forEachField in ReflectionMirror.swift
already gives the offsets and types for each field, this isn't
enough information to construct a keypath for that field in
order to modify it.
For reference, this should be sufficient to implement the features
described here: (https://forums.swift.org/t/storedpropertyiterable/19218/62)
purely at runtime without any derived conformances for many types.
Note: Since there isn't enough reflection information for constructing
.mutatingGetSetfields, this means that we're not able to supportreflecting certain types of fields (functions, non-final class fields,
etc). Whether this is an error or not is controlled by the
.ignoreUnknownoption.