Allow the creation of a shadow variable when the type is a refcounted pointer #34835
Conversation
|
@swift-ci smoke test |
|
|
|
@swift-ci smoke test OS X |
|
Thanks, this LGTM! Could you add an API test to LLDB that makes use of this? |
|
Oh: you did swiftlang/llvm-project#2156 ? |
Yes! That test is for this problem. |
|
There's a failure in https://ci.swift.org/job/swift-PR-osx-smoke-test/26103/consoleFull#-3473459473122a513-f36a-4c87-8ed7-cbc36a1ec144: The test defines:
I don't see how the failure is related to this change. |
|
|
|
I've made a note to investigate those failures. Let's try again for now. |
|
@swift-ci smoke test |
Hi @vedantk, that's what I suspect as well. I checked out the llvm-project commit that was used in the test, and the same test fails with or without my changes. The problem is that a bunch (280) tests are failing in my system at the moment, and I wanted to sort this to make sure there weren't any problems in my patch before commenting anything. Also, I didn't see any other failures like this one in the CI, which left me puzzled. But since you've mentioned this already, maybe we could try re-running the tests? |
|
I see you already re-started the tests. Thanks! |
|
Augh "Targeted branch is locked (Holiday)" |
|
Hi guys! It looks like the previous failures were unrelated to the PR. Could we re-run the tests here? |
* 'main' of github.com:apple/swift: (67 commits) [build-script] Allow to tune dsymutil parallelism (swiftlang#34795) [Testing] Add missing REQUIRES [concurrency] SILGen: emit @asyncHandler functions. [concurrency] SILGen: allow the Builtin.createAsyncTaskFuture to have a non-generic closure argument. [concurrency] stdlib: add a _runAsyncHandler compiler intrinsic. Mangling: add support for mangling the body-function of asyncHandlers Make sure ~AutoDiffLinearMapContext() is called. fix SourceLoc-related crasher and add tests [AutoDiff] Bump-pointer allocate pullback structs in loops. (swiftlang#34886) update differentiable programming manifesto [Async CC] Always add full type metadata to bindings. [cxx-interop] Fix assertion to allow variadic members. [ome] Remove bad pattern of having a global SILBuilder with a global SILBuilderWithContext and multiple local SILBuilderWithScope. [ome] Invoke simplifyInstruction after lowering ownership and use replaceAllSimplifiedUsesAndErase instead of a manual RAUW. Partially revert Float16 availability changes (swiftlang#34847) Add a field reflection function that constructs keypaths. (swiftlang#34815) Allow the creation of a shadow variable when the type is a refcounted pointer (swiftlang#34835) [CMake] Extend copy-legacy-layouts dependency to swiftmodules (swiftlang#34846) [sil] Remove usage from TypeLowering of SILBuilder::create*AndFold(). [allocbox-to-stack] Fix an ossa bug in PromotedParamCloner. ...
This PR allows the creation of shadow variables when dealing of variable whose type is as a refcounted pointer in -O0. This allows debug information to survive when it otherwise wouldn't.
Resolves SR-13208.
@adrian-prantl @vedantk