[5.4] [Type checker] Ensure we sort semantic members properly. #35385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When evaluating the semantic members request, we would sort the members before we return them to ensure a stable ordering for (e.g.) vtable layout. However, when not in a source file, we would assume that the resulting members were always sorted. However, they are not always sorted, because we write the iterative decl contexts directly rather than writing the semantic members. Fixes rdar://72833032. (cherry picked from commit 5426117)
|
@swift-ci please test |
|
Windows failure doesn't make sense: |
|
Obsoleted in favor of #35540 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When evaluating the semantic members request, we would sort the members
before we return them to ensure a stable ordering for (e.g.) vtable
layout. However, when not in a source file, we would assume that the
resulting members were always sorted. However, they are not always
sorted, because we write the iterative decl contexts directly rather
than writing the semantic members.
Fixes rdar://72833032.