[5.4] Introduce "all members" query to reduce non-determinism in serialization & interface printing #35540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When evaluating the semantic members request, we would sort the members before we return them to ensure a stable ordering for (e.g.) vtable layout. However, when not in a source file, we would assume that the resulting members were always sorted. However, they are not always sorted, because we write the iterative decl contexts directly rather than writing the semantic members. Fixes rdar://72833032. (cherry picked from commit 5426117)
(cherry picked from commit 3dc4c78)
The "semantic members" query produces the list of members that can affect the ABI, e.g., of classes. It does not produce the complete list of members suitable for semantic queries. (cherry picked from commit a8f7f0d)
Introduce an "all members" request to compute all of the members of a given iterable declaration context in stable order. This builds on ABI members so that it will also include, e.g., type aliases synthesized for associated types. (cherry picked from commit c4e265e)
When serializing the members of a nominal type or extension, use `getAllMembers()` instead of `getMembers()` to provide a deterministic ordering. Fixes rdar://63294687. (cherry picked from commit ce12778)
Use getAllMembers() when printing members to get deterministic ordering. (cherry picked from commit 85cd87a)
…sses (cherry picked from commit 76e6f15)
(cherry picked from commit 5897dbe)
(cherry picked from commit 5e8ed8d)
…uery. The "synthesized" bit of declarations was never serialized, so sorting deserialized declarations was already a no-op. Make it explicitly a no-op to save some work. The fact that we serialize deterministically is what actually fixed the problem here. (cherry picked from commit 344747c)
|
@swift-ci please test |
airspeedswift
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate some problematic sources of non-determinism involving the ordering of the members within an iterable declaration context. This pull request does a few things in that direction:
hashValue), enums (likeCodingKeys), and type aliases (inferred from associated types).hashValue.The combination of the second and third bullets fixes rdar://63294687, a crash that occurs due to the synthesized
hashValueproperty getting a different vtable slot in the defining module vs. a client module.Cherry-pick of #35523