[concurrency] fixes for conformance to async ObjC protocol requirements #35662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
force-pushed
the
objc-async-conformance-bugs
branch
from
9c21b4a to
884f2b5
Compare
|
@swift-ci please smoke test macOS platform |
kavon
force-pushed
the
objc-async-conformance-bugs
branch
3 times, most recently
from
f14a14d to
fb1a268
Compare
While a Swift protocol can have its async requirements satisfied by a sync witness, this is not the case for ObjC protocols because it is not just a calling convention difference. Because every async ObjC function requirement in the protocol also has a sibling that is sync, a sync witness might be trying to conform to the sync version that takes a completion handler. Without this change, we were seeing an issue where we would consider both the async and sync versions of an ObjC requirement, and accidentially choose the async version when the witness was sync, and then raise an error about the typechecker's mistake. Instead of raising an error, this change removes the ability for the typechecker to even consider the errornous conformance. resolves rdar://73326234
kavon
force-pushed
the
objc-async-conformance-bugs
branch
from
fb1a268 to
ff54f3b
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
DougGregor
approved these changes
Feb 2, 2021
|
@swift-ci please smoke test |
|
Build failed |
|
Build failed |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix and add more coverage for conformance checking of ObjC protocols that contain a requirement that can be conformed to in different ways by a Swift type: either as the ordinary sync version or an
asyncversion.TODOs:
Fix unusual note that claims a protocol's requirements are not satisfied (rdar://73641790).Will fix in a separate PR.Fix a conformance serialization issue that might be related to the unusual note (rdar://73326224).Will fix in a separate PR.a continuation of this work is in #35719