[concurrency][Part 2] Fix async objc protocol conformance bugs #35719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
kavon
force-pushed
the
objc-async-conformance-bugs-2-electric-boogaloo
branch
from
d54b0b8 to
26090a1
Compare
kavon
force-pushed
the
objc-async-conformance-bugs-2-electric-boogaloo
branch
from
26090a1 to
472013b
Compare
|
@swift-ci please clean smoke test |
kavon
force-pushed
the
objc-async-conformance-bugs-2-electric-boogaloo
branch
from
472013b to
c8d1f53
Compare
|
@swift-ci please clean smoke test |
kavon
force-pushed
the
objc-async-conformance-bugs-2-electric-boogaloo
branch
from
c8d1f53 to
9f60f3a
Compare
|
@swift-ci please smoke test |
kavon
force-pushed
the
objc-async-conformance-bugs-2-electric-boogaloo
branch
from
9f60f3a to
9db771b
Compare
|
@swift-ci please smoke test and merge |
kavon
force-pushed
the
objc-async-conformance-bugs-2-electric-boogaloo
branch
from
9db771b to
388abdd
Compare
|
@swift-ci please smoke test and merge |
DougGregor
approved these changes
Feb 6, 2021
kavon
force-pushed
the
objc-async-conformance-bugs-2-electric-boogaloo
branch
from
388abdd to
adf6780
Compare
This really only happens when the ClangImporter imports an ObjC protocol that has an async-looking method, which yields two requirements in the protocol. Only one of these requirements will be witnessed. fixes rdar://73326224
kavon
force-pushed
the
objc-async-conformance-bugs-2-electric-boogaloo
branch
from
adf6780 to
739617c
Compare
|
Okay I've refactored it use a search that relies on a predicate, because the use-sites have different requirements. For example, @swift-ci please test and merge |
|
@swift-ci please smoke test and merge |
kavon
added a commit
to kavon/swift
that referenced
this pull request
Feb 9, 2021
This adds regression test coverage for a situation related to rdar://73326085, but was just recently fixed in: swiftlang#35719
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #35662
TODOs:
Fix unusual note that claims a protocol's requirements are not satisfied (rdar://73641790).The conformance diagnostic should not be encountered at all.Make an error also be emitted alongside this missing witness note.Determine whether an error should have been encountered at all.