Make Error and CodingKey conform to ConcurrentValue. #36070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves source compatibility in cases where a marker protocol is introduced after-the-fact (e.g., for `Error`), and is safe because there's no runtime component to marker protocols.
… protocols These conditional conformances could not be properly evaluated at runtime, so ban them. We still allow conditional conformances to marker protocols.
Make both Error and CodingKey conform to ConcurrentValue, so that thrown errors always conform to ConcurrentValue. Downgrade (to warnings) and ConcurrentValue-related diagnostics that are triggered by this change in existing Error and CodingKey-conforming types to reduce the impact on source compatibility.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
Build failed |
|
@swift-ci please test macOS |
|
@swift-ci please smoke test macOS |
ktoso
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make both Error and CodingKey conform to ConcurrentValue, so that
thrown errors always conform to ConcurrentValue. Downgrade (to
warnings) and ConcurrentValue-related diagnostics that are triggered
by this change in existing Error and CodingKey-conforming types to
reduce the impact on source compatibility.