Skip to content

Revert "Make Error and CodingKey conform to ConcurrentValue." #36088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "Make Error and CodingKey conform to ConcurrentValue." #36088

wants to merge 1 commit into from

Conversation

eeckstein
Copy link
Contributor

@eeckstein eeckstein commented Feb 22, 2021 •
edited
Loading

Reverts #36070

It breaks the api-digester/stability-stdlib-abi-without-asserts.test.

rdar://74594091

@eeckstein
Copy link
Contributor Author

@swift-ci smoke test

@eeckstein eeckstein requested a review from DougGregor February 22, 2021 14:17
@DougGregor
Copy link
Member

The fix is at #36089

@eeckstein eeckstein closed this Feb 22, 2021
@eeckstein
Copy link
Contributor Author

ok, thanks. Then no need to revert

@shahmishal shahmishal deleted the revert-36070-concurrentvalue-error-codingkey branch May 13, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor Awaiting requested review from DougGregor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eeckstein @DougGregor