-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[docs] Update SIL.rst #36131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update SIL.rst #36131
Conversation
@swift-ci Please test |
Thanks for resolving this! |
Thanks |
Build failed |
@swift-ci please smoke test |
The swift-ci test (or smoke test) doesn't appear to build the HTML documentation.
But I don't know if swift-ci toolchains or nightly snapshots will be broken? Can the |
@swift-ci please smoke test Linux platform |
I think this should be okay. We don't have warnings as errors turned on for CI either. That said, I don't remember how long building the docs takes and whether it is happening serially or in parallel, so I'm not sure if we should be building the docs in CI by default... (is that what you're suggesting?) |
No, I'm only suggesting that a broken link in documentation isn't serious enough to justify a complete build failure. Since the docs_html phase isn't tested by swift-ci, we won't notice the failure until someone reports it. |
Okay, yeah that sounds reasonable. FWIW, I'm okay with removing the |
Follow-up to: #35993 (comment)
View file: docs/SIL.rst#is-unique