docs: Convert ARCOptimization.rst to Markdown #35993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
force-pushed
the
arcoptimization-md
branch
from
129b677 to
71ab004
Compare
|
@swift-ci please smoke test |
docs/ARCOptimization.md
Outdated
Comment on lines
19
to
29
| - `strong_retain` | ||
| - `strong_release` | ||
| - `strong_retain_unowned` | ||
| - `unowned_retain` | ||
| - `unowned_release` | ||
| - `load_weak` | ||
| - `store_weak` | ||
| - `fix_lifetime` | ||
| - `mark_dependence` | ||
| - `is_unique` | ||
| - `copy_block` |
There was a problem hiding this comment.
You can remove the additional spacing between - and the backtick.
docs/ARCOptimization.md
Outdated
Comment on lines
311
to
318
| > - Native object types are directly checked by reading the strong | ||
| > reference count: (Builtin.NativeObject, known native class | ||
| > reference) | ||
| > - Objective-C object types require an additional check that the | ||
| > dynamic object type uses native Swift reference counting: (unknown | ||
| > class reference, class existential) | ||
| > - Bridged object types allow the dynamic object type check to be | ||
| > bypassed based on the pointer encoding: (Builtin.BridgeObject) |
There was a problem hiding this comment.
Maybe this was accidentally marked as a quote? Seems a bit odd... It seems like it is stating the rules, and not quoting rules stated elsewhere.
MaxDesiatov
force-pushed
the
arcoptimization-md
branch
from
71ab004 to
2e45839
Compare
|
@swift-ci please smoke test |
MaxDesiatov
changed the title
|
There's also a link in docs/README.md. |
|
Thanks, that's fixed now. |
MaxDesiatov
force-pushed
the
arcoptimization-md
branch
from
10e31f4 to
699c3ed
Compare
benrimmington
approved these changes
Feb 23, 2021
|
@swift-ci please smoke test and merge |
varungandhi-apple
approved these changes
Feb 23, 2021
MaxDesiatov
force-pushed
the
arcoptimization-md
branch
from
699c3ed to
e7e28cc
Compare
|
@swift-ci please smoke test |
|
@swift-ci Please smoke test Linux platform |
|
@swift-ci please test Windows platform |
This breaks the doc compilation which in turns breaks the complete build. Please revert, thank you. |
Merged
@Teemperor Possible fix: #36131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently docs are a mix of reStructuredText and Markdown and unifying them as Markdown would make more sense long term, as far as I understand. This converts
ARCOptmization.rst, initially converted with Pandoc with manual cleanup added after the fact.