[docs] Update the sphinx-build options
#36158
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS platform |
|
Sorry, I don't think I'm the right person to review Swift patches. |
eeckstein
reviewed
Feb 26, 2021
There was a problem hiding this comment.
I think we should keep the doc build failing if there is a problem.
Instead we should add the doc build process to PR testing.
@shahmishal any chance we can do this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-Wwarnings as errors option can cause external builds to fail:The
-Woption could either be removed, or replaced with:-nnit-picky mode, and/or-qstandard error mode.(There's also a
SPHINXOPTSenvironment variable.)Note: The HTML documentation isn't built or tested by swift-ci.