[libSyntax] Miscellaneous minor improvements #36229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
The data of an OpaqueSyntaxNode should never be modified. Also, this allows us to get rid of two const_casts.
It doesn't do anything anymore and we shouldn't have it, so let's just remove it.
ahoppen
force-pushed
the
pr/opaque-const-pointer-and-delete-discarednode
branch
from
99e04c8 to
dc8eed4
Compare
|
Full test suite passed earlier. Just running smoke tests after rebasing onto @swift-ci Please smoke test |
rintaro
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a collection of minor improvements to libSyntax
OpaqueSyntaxNodeto be aconst void *pointer instead ofvoid *since its data is not supposed to be modifieddiscaredRecordedNode. SinceRawSyntaxis no longer reference counted, none of the implementations did anything and the comment in there says, we should get rid of it anyway.