Skip to content

[Build Script] Install libDispatch only after all builds are complete. #36428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Build Script] Install libDispatch only after all builds are complete. #36428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions utils/build-script
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1008,6 +1008,11 @@ class BuildScriptInvocation(object):
# Install...
for host_target in all_hosts:
for product_class in impl_product_classes:
# We cannot install libdispatch until after all builds are complete
# as that will cause the Dispatch module to be imported twice and
# fail to build.
if (product_class == products.LibDispatch):
continue
self._execute_install_action(host_target, product_class)

# Core Lipo...
Expand Down Expand Up @@ -1047,6 +1052,11 @@ class BuildScriptInvocation(object):
print("--- Installing %s ---" % product_name)
product.install(host_target)

# Do not forget installing libDispatch
if products.LibDispatch in impl_product_classes:
for host_target in all_hosts:
self._execute_install_action(host_target, products.LibDispatch)

# Extract symbols...
for host_target in all_hosts:
self._execute_extract_symbols_action(host_target)
Expand Down