Add test case for rethrows functions with defaulted throwable argument functions #36455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Left a couple of comments that maybe make sense, but let me know WDYT @varungandhi-apple :)
varungandhi-apple
approved these changes
Mar 17, 2021
|
@swift-ci smoke test |
Alright! I'll fix that, thanks. |
The first test case added ideally shouldn't have any expected error or diagnostic. However, due to SR-1534, there is an error emitted here. Thus, an expected error is used here to show the compiler's behavior today. If SR-1534 is fixed in the future, the first test case should no longer have any expected error nor an expected note. However, the second test case should still be left alone. Addresses SR-14270
|
Oh, I wasn't expecting you'd fix it, since it wasn't a big deal, but thanks for doing that. 😄 @swift-ci smoke test |
|
@swift-ci Please smoke test Linux Platform |
|
@swift-ci Please test Windows Platform |
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two test cases were added, both of which with an expected error "call can throw but is not marked with 'try'" and expected note "call is to 'rethrows' function, but a defaulted argument function can throw". These help someone to understand when the note should be emitted.
The first test case relates to SR-1534. Ideally it has no expected errors or notes, but because of that bug, it currently emits one. The second test case should always have the error and note regardless of whether SR-1534 is fixed.
Resolves SR-14270.