Gardening: Migrate test suite to GH issues p. 9 #60718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
commented
Aug 23, 2022
| func nonThrowableDefaultRethrows(_ f: () throws -> () = {}) rethrows { | ||
| try f() | ||
| } | ||
| // NOTE: This should compile and not emit a diagnostic because ideally the compiler could statically | ||
| // know the default argument value could never throw. See SR-1524. |
AnthonyLatsis
force-pushed
the
migrate-test-suite-to-gh-issues-9
branch
from
c85ac49 to
93c964f
Compare
AnthonyLatsis
commented
Aug 26, 2022
Comment on lines
-545
to
+547
| static func fn(_ x: @escaping () -> Int) -> SR_10084_E_2 { // Okay | ||
| fatalError() | ||
| } | ||
| static func fn(_ x: @escaping () -> Int) -> E2_52486 {} // Okay |
There was a problem hiding this comment.
I am taking the liberty to remove some of these dummy returns within code I modified, since they present unnecessary noise and, conveniently, are mostly optional until after semantic analysis. Let me know if you consider this a bit too invasive.
xedin
approved these changes
Aug 26, 2022
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.