Add test case for rdar://71566576 #36495
Conversation
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
|
@swift-ci Please smoke test Linux |
| @@ -0,0 +1,3 @@ | |||
| // RUN: %swift-ide-test -code-completion -code-completion-token=COMPLETE -source-filename %s | |||
|
|
|||
| if let item = ["a"].first(where: { #^COMPLETE^# }) {} | |||
There was a problem hiding this comment.
Does it need to check actual completions produced here or was it a crasher?
There was a problem hiding this comment.
It was a crasher. Do you think it would be worthwhile still checking that we actually produce some completions?
There was a problem hiding this comment.
It's up to you if the completions are good :) If it's just to make sure that compiler doesn't crash I'd suggest we move this to validation-test/IDE/crashers_fixed
There was a problem hiding this comment.
Thanks for the pointer. I didn’t know about validation-test/IDE/crashers_fixed. Already applied the new knowledge to #36523 😉
rdar://71566576 appears to have been fixed already. Still, add a test case for it to ensure we don’t hit it again.
ahoppen
force-pushed
the
pr/rdar71566576
branch
from
45ec3e7 to
dc88b4b
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Windows |
rdar://71566576 [SR-13877] appears to have been fixed already. Still, add a test case for it to ensure we don’t hit it again.