Revert "Sema: Remove some unreachable code from CSApply" #36523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
This was referenced Mar 19, 2021
xedin
approved these changes
Mar 19, 2021
|
Nice find! Probably some parts of that PR are almost certainly still dead, but we can wait to re-apply it until we finish cleaning up code completion. |
|
Yeah, most likely the majority is still unreachable and sorry for reverting. But as you said, we can probably just re-apply it later. |
|
@swift-ci Please smoke test Windows |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #36493 and #36494, this reverts #36028 and adds the test cases from those PRs.
I have also adjusted the tests to live in
validation-test/IDE/crashers_2_fixedand useswift-ide-testinstead ofsourcekitd-test.Fixes rdar://75219757 [SR-14319] and rdar://75200446 [SR-14318]