Skip to content

re-allow symbol-graph-dir and supplementary file map #36981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

QuietMisdreavus
Copy link
Contributor

Resolves rdar://76815547

The new swift-driver does not have a port of #36542, which is causing issues in the same way that the old driver had when using whole-module optimizations (or other situations where file maps were being used). This PR re-allows -emit-symbol-graph-dir and -supplementary-output-file-map at the same time, to allow the new driver to use the frontend before it is properly updated.

@QuietMisdreavus QuietMisdreavus requested a review from artemcm April 21, 2021 00:16
@QuietMisdreavus
Copy link
Contributor Author

Using swiftlang/swift-driver#611

@swift-ci Please test

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please build toolchain macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 7054118

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - 7054118

Install command
tar -zxf swift-PR-36981-954-osx.tar.gz --directory ~/

@QuietMisdreavus
Copy link
Contributor Author

After diagnosing the test failure and speaking with @artemcm, we've decided that the best way forward is to revert the symbol-graph file map implementation entirely, so that the two drivers can be in sync. That PR is opened now at #37017.

@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus/allow-symbol-supplementary-again branch April 22, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants