Revert "[Driver][Frontend] add the symbol graph dir to the supplementary file map" #37017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the new driver fails when running this test, because the file map and the command-line specify the same module output for both the individual swift file and the module as a whole
|
Using swiftlang/swift-driver#611 @swift-ci Please test |
|
@swift-ci Please build toolchain macOS platform |
artemcm
approved these changes
Apr 22, 2021
|
macOS Toolchain Install command |
QuietMisdreavus
deleted the
revert-36542-QuietMisdreavus/supplementary-symbol-graph
branch
QuietMisdreavus
restored the
revert-36542-QuietMisdreavus/supplementary-symbol-graph
branch
shahmishal
deleted the
revert-36542-QuietMisdreavus/supplementary-symbol-graph
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #36542
Resolves rdar://76815547
Due to the implementation differences between the old and new drivers, there were issues where trying to emit symbol graphs with whole-module optimization and the new driver would cause an error. This PR reverts the implementation in the old driver and frontend to bring the drivers in sync.