Skip to content

[5.5] Revert "[Driver][Frontend] add the symbol graph dir to the supplementary file map" #37569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2021

Conversation

QuietMisdreavus
Copy link
Contributor

Resolves rdar://78312183

When #37017 was posted, the release/5.5 branch had been cut. However, the PR was only applied to main. This means that the issue that that PR was meant to fix is still present on the release/5.5 branch. This PR applies the reversion (and the test fix that allowed swift-driver to run the SymbolGraph/EmitWhileBuilding test) to release/5.5.

QuietMisdreavus and others added 2 commits May 21, 2021 10:11
the new driver fails when running this test, because the file map and
the command-line specify the same module output for both the individual
swift file and the module as a whole
@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please build toolchain macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 6a71733

@QuietMisdreavus
Copy link
Contributor Author

Linux CI failed on LLDB tests. Trying again...

@swift-ci Please test Linux platform

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - 6a71733

Install command
tar -zxf swift-PR-37569-988-osx.tar.gz --directory ~/

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 6a71733

@QuietMisdreavus
Copy link
Contributor Author

Build error on swift-driver?

<unknown>:0: error: error opening input file 'lib/libYamsTests.a' (The file was not recognized as a valid object file)

Going to try again...

@swift-ci Please test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 6a71733

@QuietMisdreavus
Copy link
Contributor Author

Saw another failure in the Linux sourcekit-lsp tests...

@swift-ci Please test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 6a71733

@QuietMisdreavus
Copy link
Contributor Author

Failed Tests (1):
  Swift(linux-x86_64) :: Sanitizers/tsan/async_taskgroup_next.swift

@swift-ci Please test Linux platform

@QuietMisdreavus QuietMisdreavus merged commit 229bb31 into release/5.5 May 24, 2021
@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus/5.5/revert-36542 branch May 24, 2021 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants