Skip to content

[Concurrency] Remove Task.current because it prevents task-local alloc #36993 #37060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2021
Merged

[Concurrency] Remove Task.current because it prevents task-local alloc #36993 #37060

merged 2 commits into from
Apr 26, 2021

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Apr 26, 2021

removes Task.current on main

@ktoso ktoso requested a review from eeckstein April 26, 2021 08:40
@ktoso
Copy link
Contributor Author

ktoso commented Apr 26, 2021

@swift-ci please smoke test and merge

@ktoso ktoso mentioned this pull request Apr 26, 2021
Closed
eeckstein
eeckstein approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@eeckstein eeckstein left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@DougGregor can you please take a look, too?

@swift-ci swift-ci merged commit cbfe3ed into swiftlang:main Apr 26, 2021
@ktoso ktoso deleted the wip-main-remove-task-current branch April 26, 2021 14:25
@ktoso ktoso requested a review from DougGregor April 27, 2021 01:34
@rjmccall rjmccall mentioned this pull request May 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeckstein eeckstein eeckstein approved these changes

@DougGregor DougGregor Awaiting requested review from DougGregor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktoso @eeckstein @swift-ci