Merge the concurrency-5.5-abi-2 branch into release/5.5 #37474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[AsyncLet] reimplemented with new ABI and builtins [AsyncLet] remove runChild; it is now asyncLetStart [AsyncLet] ending an async let cancels the task [AsyncLet] remove some commented out code [AsyncLet] silence issue on windows [Concurrency] Store child record when async let child task spawned [AsyncLet] reimplemented with new ABI and builtins [AsyncLet] remove runChild; it is now asyncLetStart [AsyncLet] ending an async let cancels the task [AsyncLet] remove some commented out code
The closure does not escape the startAsyncLet - endAsyncLet scope. Even though it's (potentially) running on a different thread. The substantial change in the runtime is to not call swift_release on the closure context if it's a non-escaping closure.
When the closure of startAsyncLet is no-escaping, the captured values (= the partial_apply arguments) must be kept alive until the endAsyncLet builtin. ClosureLifetimeFixup adds the generated mark_dependence as a second operand to endAsyncLet, which keeps all the arguments alive until this point.
- Introduce an UnownedSerialExecutor type into the concurrency library. - Create a SerialExecutor protocol which allows an executor type to change how it executes jobs. - Add an unownedExecutor requirement to the Actor protocol. - Change the ABI for ExecutorRef so that it stores a SerialExecutor witness table pointer in the implementation field. This effectively makes ExecutorRef an `unowned(unsafe) SerialExecutor`, except that default actors are represented without a witness table pointer (just a bit-pattern). - Synthesize the unownedExecutor method for default actors (i.e. actors that don't provide an unownedExecutor property). - Make synthesized unownedExecutor properties `final`, and give them a semantics attribute specifying that they're for default actors. - Split `Builtin.buildSerialExecutorRef` into a few more precise builtins. We're not using the main-actor one yet, though. Pitch thread: https://forums.swift.org/t/support-custom-executors-in-swift-concurrency/44425
and traffic in Optional<Builtin.Executor> in various places.
Previously, they were storing a low-bit flag that indicated that they were a default actor. Using an extra inhabitant frees up the low bit for future use without being conspicuously more expensive to check.
…5-abi-2 Conflicts: include/swift/Basic/Features.def
…ator. Also, do this for the initial slab for the task's allocator itself. This avoids memory allocations for async-lets. In case the async-task's memory demand does not exceed the initial slab size, it is now completely malloc-free. The refcount bits of an async-let task are initialized to "immortal" so that ARC operations don't have an effect on the task. (cherry picked from commit 075ad87)
This commit changes JobFlags storage to be 32bits, but leaves the runtime API expressed in terms of size_t. This allows us to pack an Id in the 32bits we freed up. The offset of this Id in the AsyncTask is an ABI constant. This way introspection tools can extract the currently running task identifier without any need for special APIs. (cherry picked from commit bbda706)
(cherry picked from commit 6ea3163)
…5.5-abi-2/update-checkout-scheme-concurrency-5.5-abi-2 Add scheme for concurrency-5.5-abi-2
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
Asking for reviews from the contributors who made functionality changes on this branch |
rdar://77564014
|
@swift-ci Please test |
ktoso
approved these changes
May 18, 2021
fredriss
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes a cherry-pick of #37060, which was meant to go into the 5.5 branch.