Restrict uses of 'self' in actor initializers #37075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
added
bug
kavon
force-pushed
the
actor-initializers
branch
4 times, most recently
from
50e9e5f to
d3a7ea4
Compare
kavon
force-pushed
the
actor-initializers
branch
from
d3a7ea4 to
61e7f76
Compare
|
@swift-ci please smoke test |
kavon
force-pushed
the
actor-initializers
branch
6 times, most recently
from
1efbe77 to
b2db522
Compare
kavon
force-pushed
the
actor-initializers
branch
3 times, most recently
from
351bcf7 to
c696312
Compare
|
@swift-ci please smoke test |
kavon
force-pushed
the
actor-initializers
branch
from
c696312 to
cdba933
Compare
|
@swift-ci please smoke test |
kavon
changed the title
kavon
force-pushed
the
actor-initializers
branch
from
cdba933 to
af36655
Compare
|
@swift-ci please smoke test |
ktoso
reviewed
Jun 23, 2021
| if (auto decl = | ||
| dyn_cast_or_null<ClassDecl>(getASTType()->getAnyNominal())) | ||
| // is it for an actor? | ||
| if (decl->isActor() && !decl->isDistributedActor()) // FIXME(78484431) skip distributed actors for now, until their initializers are fixed! |
|
Turns out that I missed one case of escaping: Working on getting the above rejected as an error on that store of |
A uniqueness rule for 'self' is enforced throughout the following types of actor initializers: 1. synchronous 2. global-actor isolated This means that 'self' cannot be used for anything, even after 'self' is fully initialized, other than for access to stored properties. Method calls are considered escaping uses of 'self', since it is passed implicitly to the method of computed property when invoked. Also, an actor's convenience init now treats self as nonisolated. This provides a way to perform follow-up work after self is fully initialized, when creating the actor from a synchronous context. Resolves rdar://78790369
kavon
force-pushed
the
actor-initializers
branch
from
2280fcd to
f722ccd
Compare
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following:
Actors permit synchronous initializers, and initializers isolated to a global-actor, which makes it difficult to both create the actor-instance and switch to it within the initializer function. Thus, data races can be created with the initializer. This PR fixes this by broadly restricting the uses of
selfin such initializers to ensure that one unique reference toselfexists throughout theinit.When I added support for async initializers, I deferred the appropriate insertion ofDeferred to a later PRhop_to_executorin actor initializers because it's not so simple to determine where that should take place. This PR fixes that and emits the hop.Resolves rdar://76620928