[5.5] Restrict uses of 'self' in actor initializers #38043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
added
bug
|
@swift-ci please test |
ktoso
approved these changes
Jun 23, 2021
|
Build failed |
A uniqueness rule for 'self' is enforced throughout the following types of actor initializers: 1. synchronous 2. global-actor isolated This means that 'self' cannot be used for anything, even after 'self' is fully initialized, other than for access to stored properties. Method calls are considered escaping uses of 'self', since it is passed implicitly to the method of computed property when invoked. Also, an actor's convenience init now treats self as nonisolated. This provides a way to perform follow-up work after self is fully initialized, when creating the actor from a synchronous context. Resolves rdar://78790369
kavon
force-pushed
the
5.5-restricted-self-actorinit
branch
from
e887f5c to
2e61dfe
Compare
|
@swift-ci please test |
This is a follow-up to the changes that restrict uses of 'self' in certain actor initializers, to guide people to using the convenience inits for now.
|
@swift-ci please test |
|
@swift-ci nominate |
DougGregor
approved these changes
Jun 25, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Actor initializers permit races due to unrestricted use of 'self', and this radar plugs that hole by rejecting unsafe uses of 'self'.
Risk: Low. Any developers that have written non-trivial code in an actor's initializer will be affected by a source break. This primarily would be early adopters of actors, and will not affect any uses of @mainactor.
Original PRs: #37075 and #38096
Radar/SR Issue: rdar://78790369
Reviewed By: Konrad Malawski
Testing: Regression tests are included