[Build] allow to generate symbols for a subset of binaries #37120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edymtt
force-pushed
the
darwin-symroot-path-filters
branch
from
c3b5d73 to
dc76660
Compare
edymtt
changed the title
edymtt
force-pushed
the
darwin-symroot-path-filters
branch
from
b040369 to
f2b31c3
Compare
|
@swift-ci please smoke test |
|
@swift-ci Please Build Toolchain |
|
@swift-ci please smoke test macOS |
|
Linux Toolchain (Ubuntu 16.04) Install command |
|
@swift-ci please smoke test macOS |
|
@swift-ci Please Build Toolchain macOS |
|
macOS Toolchain Install command |
|
@swift-ci please smoke test macOS |
gottesmm
reviewed
May 4, 2021
There was a problem hiding this comment.
Looks good so far... can you make the changes/look into my questions. Then I want to do another quick go over/read the tests in a deeper way. Ping me to do another go around and assuming no further issues and the tests from first principles test everything we need, this will LGTM.
validation-test/BuildSystem/extractsymbols-no-file-to-process.test
Outdated
Show resolved
Hide resolved
validation-test/BuildSystem/extractsymbols-darwin-symroot-path-filters.test
Outdated
Show resolved
Hide resolved
validation-test/BuildSystem/extractsymbols-default-behaviour.test
Outdated
Show resolved
Hide resolved
edymtt
commented
May 5, 2021
validation-test/BuildSystem/extractsymbols-darwin-symroot-path-filters.test
Outdated
Show resolved
Hide resolved
edymtt
force-pushed
the
darwin-symroot-path-filters
branch
from
f2b31c3 to
d3fb1c7
Compare
|
@swift-ci please smoke test |
|
@swift-ci Please Build Toolchain |
|
Linux Toolchain (Ubuntu 16.04) Install command |
|
macOS Toolchain Install command |
|
A quick check of the log shows that python files and compatibility libraries are copied to the symroot |
gottesmm
approved these changes
May 11, 2021
validation-test/BuildSystem/extractsymbols-no-file-to-process.test
Outdated
Show resolved
Hide resolved
validation-test/BuildSystem/extractsymbols-darwin-symroot-path-filters.test
Show resolved
Hide resolved
...before adding the logic to filter paths In particular: * print the list of files that `cpio` copies, so we can test explicitly which files end up in the symroot (and also see those when asking for a toolchain in PR testing) * use `find` instead of `grep` to filter files we want symbols generated for -- this is to avoid the script failing when there are no symbol to process, especially in lit tests * remove an unnecessary check for `swift-api-digester` -- this is now a symlink to `swift-frontend` and we only process regular files. Supports rdar://76865276
This would be needed to reduce overall build times in scenarios when generating symbols for all binaries is too expensive and/or not needed. Addresses rdar://76865276
edymtt
force-pushed
the
darwin-symroot-path-filters
branch
from
d3fb1c7 to
1e5f790
Compare
|
@swift-ci please smoke test |
|
@swift-ci Please Build Toolchain |
|
Linux Toolchain (Ubuntu 16.04) Install command |
|
macOS Toolchain Install command |
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
May 14, 2021
This was introduced to avoid indentation changes when making this logic amenable to testing in swiftlang#37120 .
LucianoPAlmeida
pushed a commit
to LucianoPAlmeida/swift
that referenced
this pull request
May 27, 2021
…wiftlang#37428) This was introduced to avoid indentation changes when making this logic amenable to testing in swiftlang#37120 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be needed to reduce overall build times in scenarios when
generating symbols for all binaries is too expensive and/or not needed.
At the same time, introduce tests around the logic that handles symbols.
Addresses rdar://76865276