[gardening] remove unnecessary condition in symbol extraction logic #37428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced to avoid indentation changes when making this logic amenable to testing in swiftlang#37120 .
|
@swift-ci please smoke test |
|
@swift-ci Please Build Toolchain |
|
(Using "Hide whitespace changes" should show more clearly which lines are removed and which lines have changed indentation) |
|
Linux Toolchain (Ubuntu 16.04) Install command |
|
macOS Toolchain Install command |
|
Skimmed the log for the toolchain, all the expected files are copied to the symroot, and dsymutil and strip run on those files |
|
Retesting my changes after the test change I did in #37488 |
|
@swift-ci please smoke test |
LucianoPAlmeida
pushed a commit
to LucianoPAlmeida/swift
that referenced
this pull request
May 27, 2021
…wiftlang#37428) This was introduced to avoid indentation changes when making this logic amenable to testing in swiftlang#37120 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced to avoid indentation changes when making this logic
amenable to testing in #37120 .