Skip to content

fix missing effects specifiers on some properties in swiftinterface #37156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2021
Merged

fix missing effects specifiers on some properties in swiftinterface #37156

merged 1 commit into from
Apr 30, 2021

Conversation

kavon
Copy link
Member

@kavon kavon commented Apr 30, 2021 •
edited
Loading

I missed the case where the body was requested to be printed in the interface file. That is, in ASTPrinter.cpp this is the case when PrintAccessorBody is true in this branch:

auto PrintAccessor = [&](AccessorKind Kind) -> bool {
    // ...
    if (!PrintAccessorBody) {
    // had already covered this
   } else {
   // forgot to cover this side!
   }
   // ...
}

Resolves rdar://77324796

@kavon kavon added bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. concurrency Feature: umbrella label for concurrency language features labels Apr 30, 2021
@kavon
Copy link
Member Author

kavon commented Apr 30, 2021

@swift-ci please smoke test and merge

@kavon kavon force-pushed the eff-prop-extension-interface-bug branch from bd0b7f3 to 47b32e1 Compare April 30, 2021 03:24
@kavon
Copy link
Member Author

kavon commented Apr 30, 2021

@swift-ci please smoke test and merge

ktoso
ktoso approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM AFAICS

@kavon
fix missing effects specifiers on eff props in swiftinterface
c1f48c6 
I missed the case where the body is also being printed in the
interface file.
@kavon kavon force-pushed the eff-prop-extension-interface-bug branch from 47b32e1 to c1f48c6 Compare April 30, 2021 03:30
@kavon
Copy link
Member Author

kavon commented Apr 30, 2021

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 7be0429 into swiftlang:main Apr 30, 2021
@kavon kavon deleted the eff-prop-extension-interface-bug branch April 30, 2021 15:17
@kavon kavon mentioned this pull request Apr 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. concurrency Feature: umbrella label for concurrency language features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kavon @ktoso @swift-ci