Skip to content

[5.5] fix missing effects specifiers on some properties in swiftinterface #37175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kavon
Copy link
Member

@kavon kavon commented Apr 30, 2021

Cherry-pick for 5.5 of #37156 and #37190 to resolve rdar://77324796

I missed the case where the body is also being printed in the
interface file.
@kavon kavon added bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. r5.5 concurrency Feature: umbrella label for concurrency language features labels Apr 30, 2021
@kavon
Copy link
Member Author

kavon commented Apr 30, 2021

@swift-ci please smoke test

@kavon
Copy link
Member Author

kavon commented Apr 30, 2021

@swift-ci please test

@kavon
Copy link
Member Author

kavon commented Apr 30, 2021

@swift-ci please test and merge

@kavon
Copy link
Member Author

kavon commented May 1, 2021

@swift-ci please test

@kavon
Copy link
Member Author

kavon commented May 1, 2021

@swift-ci please test Windows platform

@swift-ci
Copy link
Contributor

swift-ci commented May 1, 2021

Build failed
Swift Test OS X Platform
Git Sha - db34e76

@DougGregor
Copy link
Member

@swift-ci please test macOS

@kavon kavon merged commit ec097d6 into swiftlang:release/5.5 May 3, 2021
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.5 bug fix and removed bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. labels Jan 8, 2023
@AnthonyLatsis AnthonyLatsis added bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. and removed bug fix labels Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. concurrency Feature: umbrella label for concurrency language features 🍒 release cherry pick Flag: Release branch cherry picks swift 5.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants