fix feature guards in swiftinterface for eff. props #37190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effectful properties were not being properly guarded for feature availability in the swiftinterface file. Previously it was only being guarded if the property was
async
and not just simplythrows
, plus, the guards were around the accessor like this:instead of around the whole decl like this
So, this patch adds two things
Features.def
for Effectful Properties (currently set to be enabled only when-enable-experimental-concurrency
is passed since I haven't enabled it by default yet).This finishes the resolution to rdar://77324796