[Refactoring] Only unwrap optionals if the handler has an optional error #37235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
force-pushed
the
async-refactoring-mixed-optional
branch
from
94de88a to
d1e3ace
Compare
|
@swift-ci please test |
|
This will need to have some changes after Alex's PR |
bnbarham
force-pushed
the
async-refactoring-mixed-optional
branch
from
d1e3ace to
73d8914
Compare
|
@swift-ci please test |
ahoppen
reviewed
May 5, 2021
Convert to async and add async alternative differ when there is no/an invalid completion handler. In those cases, also check convert to async.
Resolves rdar://73973459
bnbarham
force-pushed
the
async-refactoring-mixed-optional
branch
from
73d8914 to
398124c
Compare
|
@swift-ci please test |
|
@hamishknight @ahoppen are you both fine with this one now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added some extra tests for convert to async since it does actually vary from add async slightly.
Resolves rdar://73973459