[Refactoring] Only unwrap optionals if the handler has an optional error #37297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert to async and add async alternative differ when there is no/an invalid completion handler. In those cases, also check convert to async.
Resolves rdar://73973459
|
@swift-ci please test |
|
@swift-ci please nominate --- CCC --- Explanation: Fixes the async refactoring to properly handle mixed optional/non-optional parameters, only unwrapping them if the last parameter in the completion handler is an optional error. Radar/SR Issue: rdar://73973459 Risk: Low. Only affects the async refactoring, which has added tests for this case. Testing: Added new tests for functions with mixed optional/non-optional args. |
akyrtzi
approved these changes
May 7, 2021
AnthonyLatsis
added
swift 5.5
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks #37235
Resolves rdar://73973459