[Concurrency] Use an availability macro instead of OS versions 9999 #37244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
approved these changes
May 4, 2021
|
Let's try this with the Concurrency module first. I remain open to suggestions for a better macro name. @swift-ci Please smoke test |
mikeash
approved these changes
May 4, 2021
|
As far as naming goes, maybe |
The use of an availability macro will make it easier to update those versions to the marketing versions when they are announced. Plus internal branches can redefine only the macro for customized availability.
|
Updated with @swift-ci Please smoke test |
DougGregor
reviewed
May 4, 2021
|
Good points. I plan on adding the same macro for the standard library, however it looks like it has some left-over uses of 9999 for older versions that will need more care to turn on or avoid. I'll add it to the lit config at the same time, I didn't think of that. @swift-ci Please smoke test macOS |
|
@swift-ci Please smoke test macOS |
This was referenced May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of an availability macro will make it easier to update those versions to the marketing versions when they are announced. Plus internal branches can redefine only the macro for customized availability.