Skip to content

[5.5][Concurrency] Use SwiftStdlib 5.5 availability macro in Concurrency module and tests #37272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 13, 2021

Conversation

xymus
Copy link
Contributor

@xymus xymus commented May 5, 2021

Replace the Concurrency related placeholder availability declaration that were using the 9999 OS versions with one availability macro, centralizing the actual OS versions definition in two locations. This simplifies merging changes between branches as it causes much less merge conflicts.

@xymus xymus added the r5.5 label May 5, 2021
@xymus xymus requested a review from DougGregor May 5, 2021 17:18
@xymus xymus requested a review from a team as a code owner May 5, 2021 17:18
@xymus
Copy link
Contributor Author

xymus commented May 5, 2021

@swift-ci Please test

@xymus xymus changed the title [5.5][Concurrency] Use SwiftStdlib availability macro in Concurrency module and tests [5.5][Concurrency] Use SwiftStdlib 5.5 availability macro in Concurrency module and tests May 5, 2021
@swift-ci
Copy link
Contributor

swift-ci commented May 5, 2021

Build failed
Swift Test Linux Platform
Git Sha - f2343fd080c74b84b11dfb4976fae918a5e5d428

@swift-ci
Copy link
Contributor

swift-ci commented May 5, 2021

Build failed
Swift Test OS X Platform
Git Sha - f2343fd080c74b84b11dfb4976fae918a5e5d428

xymus added 4 commits May 12, 2021 13:16
The use of an availability macro will make it easier to update those
versions to the marketing versions when they are announced. Plus
internal branches can redefine only the macro for customized
availability.
@xymus
Copy link
Contributor Author

xymus commented May 12, 2021

@swift-ci Please test

@xymus
Copy link
Contributor Author

xymus commented May 12, 2021

@swift-ci Please nominate

@airspeedswift airspeedswift merged commit 0912fa2 into swiftlang:release/5.5 May 13, 2021
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.5 labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants