[Serialization] Skip MissingMembers when allowing errors #37553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
A normal compilation would error before merging modules when there are MissingMemberDecls, so the missing member case is unreachable. That's not true when allowing errors though, where we continue regardless. Skip the missing member instead of crashing. Resolves rdar://76365694.
bnbarham
force-pushed
the
write-members-crash
branch
from
7239d20 to
6b69867
Compare
|
Added a check for the frontend crashing without allow errors - we should never be serializing missing members in that case (it should fail before getting here). @swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
This was referenced May 21, 2021
|
Build failed |
|
Build failed |
xymus
approved these changes
May 21, 2021
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A normal compilation would error before merging modules when there are
MissingMemberDecls, so the missing member case is unreachable. That's
not true when allowing errors though, where we continue regardless. Skip
the missing member instead of crashing.
Resolves rdar://76365694.