[5.5-05142021][Serialization] Skip MissingMembers when allowing errors #37561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A normal compilation would error before merging modules when there are MissingMemberDecls, so the missing member case is unreachable. That's not true when allowing errors though, where we continue regardless. Skip the missing member instead of crashing. Resolves rdar://76365694.
|
@swift-ci please test |
bnbarham
changed the title
bnbarham
changed the title
|
@swift-ci please nominate |
airspeedswift
approved these changes
May 21, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks #37553
CCC Nomination
Explanation: When allowing compiler errors (enabled for compilations in the background indexing build arena), merge modules can crash during serialization when attempting to serialize MissingMemberDecls. A normal compilation would fail before hitting this point, hence the crash only happening during background indexing.
Scope: Background Indexing
Radar/SR Issue: rdar://76365694
Risk: Low. This change only impacts compiles allowing compiler errors, a mode exclusively used in background indexing.
Testing: Added a test case with a MissingMemberDecl that checks it no longer crashes.