Fix missing musttail for dynamic replacement calls. #37592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Build failed |
|
Build failed |
Fixes rdar://78284346. (Found when trying to land musttail verification. :D)
varungandhi-apple
force-pushed
the
vg-musttail-dynamic-replacement
branch
from
159ec9c to
a044644
Compare
|
@swift-ci test |
|
Build failed |
|
@swift-ci test macOS |
|
Revert in #37645 |
|
Reverting was the wrong thing; the test should be x-failed on Windows. #37646 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we make a tail call from swifttailcc → swifttailcc, the call should be marked musttail even when dynamic replacement is involved. However, this wasn't handled earlier, leading to an assertion failure when I tried to turn on musttail verification. (See #36805 (comment))
Fixes rdar://78284346 .