Skip to content

[5.5] [IRGen] Fix missing musttail for dynamic replacement calls. #37654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 16, 2021
Merged

[5.5] [IRGen] Fix missing musttail for dynamic replacement calls. #37654

merged 3 commits into from
Jun 16, 2021

Conversation

varungandhi-apple
Copy link
Contributor

Cherry-picks for PR #37592 and PR #37646 to 5.5.

@varungandhi-apple
Add test case for missing musttail in dynamic replacement.
9c9124e 
(cherry picked from commit 94593e4)
@varungandhi-apple
[IRGen] Fix missing musttail for dynamic replacement calls.
1aba91e 
Fixes rdar://78284346.

(Found when trying to land musttail verification. :D)

(cherry picked from commit a044644)
@varungandhi-apple
Xfail async test on Windows.
dc59efc 
The swifttailcc convention is not supported on Windows right now.

(cherry picked from commit f949909)
@varungandhi-apple varungandhi-apple requested a review from a team as a code owner May 26, 2021 17:24
@varungandhi-apple
Copy link
Contributor Author

@swift-ci test

1 similar comment
@varungandhi-apple
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented Jun 5, 2021

Build failed
Swift Test OS X Platform
Git Sha - dc59efc

@varungandhi-apple
Copy link
Contributor Author

Hit a build time out.

@swift-ci test macOS

@varungandhi-apple varungandhi-apple merged commit 52459b1 into swiftlang:release/5.5 Jun 16, 2021
@varungandhi-apple varungandhi-apple deleted the vg-5.5-musttail-dynamic-replacement branch June 16, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varungandhi-apple @swift-ci @DougGregor