Skip to content

add symbol-graph flag to include SPI symbols #37640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

QuietMisdreavus
Copy link
Contributor

Resolves rdar://70794131

This PR adds a new flag to swift-symbolgraph-extract and the frontend: -include-spi-symbols. When present, this overrides the current filter that removes symbols tagged with @_spi if the requested visibility isn't internal. It also adds a new "mixin" field, "spi", which is a boolean that is present and true for SPI symbols.

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please smoke test

@QuietMisdreavus QuietMisdreavus requested a review from bitjammer May 27, 2021 16:58
@QuietMisdreavus
Copy link
Contributor Author

The Jenkins link is a 404 for me?

@swift-ci Please smoke test Windows platform

Copy link
Contributor

@bitjammer bitjammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thank you!

@QuietMisdreavus QuietMisdreavus merged commit 40b084e into main Jun 4, 2021
@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus/spi-symbols branch June 4, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants