Skip to content

[5.5] [SymbolGraph][Driver] add symbol-graph flag to include SPI symbols #37641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

QuietMisdreavus
Copy link
Contributor

@QuietMisdreavus QuietMisdreavus commented May 25, 2021

Resolves rdar://70794131

This PR ports #37640 to release/5.5.

Change Information

  • Explanation: Adds a new field to the symbol graph, spi, and a new CLI flag, -include-spi-symbols, which facilitate generating symbol graphs with SPI symbols.
  • Scope of Issue: Currently, the only way to include SPI symbols in the symbol graph is to set the "minimum access level" to "internal" or higher, which adds a lot of excess symbols to the graph. In addition, there is currently no way to determine whether a given symbol is SPI or not.
  • Risk: Low.
  • Automated Testing: A new lit test, "SymbolGraph/Symbols/Mixins/SPI", has been added. PR testing has passed.

@QuietMisdreavus
Copy link
Contributor Author

On a whim, i'm going to try to test this, since i can get the test's command to work locally (the swiftc call that adds -include-spi-symbols) in the Xcode build, but not the Ninja build. If it works in CI, i'll call this ready to review.

@swift-ci Please test

@QuietMisdreavus QuietMisdreavus marked this pull request as ready for review May 26, 2021 15:54
@QuietMisdreavus
Copy link
Contributor Author

QuietMisdreavus commented May 26, 2021

Turns out my testing issue was a local configuration problem. After i did a clean rebuild of the compiler, everything seems to be working on my system. Marking this as ready.

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please build toolchain macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - fd26b86

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - fd26b86

Install command
tar -zxf swift-PR-37641-1002-osx.tar.gz --directory ~/

@QuietMisdreavus QuietMisdreavus requested a review from bitjammer May 27, 2021 16:58
@QuietMisdreavus
Copy link
Contributor Author

The failing test in the macOS CI is flaky and is being disabled in swiftlang/llvm-project#3005.

@swift-ci Please test macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - fd26b86

@QuietMisdreavus
Copy link
Contributor Author

It looks like that PR was merged while the CI was running, which caused an error in cloning LLVM.

@swift-ci Please test macOS platform

@QuietMisdreavus QuietMisdreavus merged commit 1d189de into release/5.5 Jun 4, 2021
@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus/5.5/spi-symbols branch June 4, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants