Skip to content

[Refactoring] Support refactoring for case let patterns #37899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jun 14, 2021

Previously we only supported case patterns that bound with a let inside the associated value like case .success(let value). With this change, we also support case let .success(value).

Fixes rdar://79279846 [SR-14772]

Previously we only supported `case` patterns that bound with a `let` inside the associated value like `case .success(let value)`. With this change, we also support `case let .success(value)`.

Fixes rdar://79279846 [SR-14772]
@ahoppen ahoppen requested a review from hamishknight June 14, 2021 10:32
@ahoppen
Copy link
Member Author

ahoppen commented Jun 14, 2021

@swift-ci Please smoke test

Copy link
Contributor

@hamishknight hamishknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahoppen
Copy link
Member Author

ahoppen commented Jun 15, 2021

@swift-ci Please smoke test Linux

@ahoppen
Copy link
Member Author

ahoppen commented Jun 15, 2021

@swift-ci Please smoke test Windows

@ahoppen
Copy link
Member Author

ahoppen commented Jun 15, 2021

Windows failure is unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants