Skip to content

[5.5][TypeChecker] NFC: Complicate perf test-case (rdar://19737632) by add… #37959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jun 17, 2021

…ing more operators

This test has become flaky in different configurations due to a varying
number of available operator overloads, let's use more operators to make
sure that it's "too complex" regardless of configuration.

Resolves: rdar://79414045

…ing more operators

This test has become flaky in different configurations due to a varying
number of available operator overloads, let's use more operators to make
sure that it's "too complex" regardless of configuration.

Resolves: rdar://79414045
@xedin xedin added the r5.5 label Jun 17, 2021
@xedin xedin requested a review from a team as a code owner June 17, 2021 00:40
@xedin
Copy link
Contributor Author

xedin commented Jun 17, 2021

@swift-ci test Apple Silicon macOS platform

@xedin
Copy link
Contributor Author

xedin commented Jun 17, 2021

@shahmishal Is think LLBuild issue being tracked somewhere? Looks like last successful run was on Jun 3...

@xedin
Copy link
Contributor Author

xedin commented Jun 17, 2021

@swift-ci test Apple Silicon macOS platform

@varungandhi-apple
Copy link
Contributor

There was one llbuild issue that should be fixed by swiftlang/swift-llbuild#730, is that what you were referring to?

@xedin
Copy link
Contributor Author

xedin commented Jun 17, 2021

@varungandhi-apple It's not a test issue, it's failing build:

20:27:32 SIL verification failed: external declarations of SILFunctions with shared visibility is not allowed: SingleFunction || !hasSharedVisibility(RefF->getLinkage()) || RefF->hasForeignBody()
20:27:32 Verifying instruction:
20:27:32 ->   // function_ref specialized static SignedInteger.isSigned.getter
20:27:32   %125 = function_ref @$sSZsE8isSignedSbvgZs4Int8V_Tgq5 : $@convention(method) (@thick Int8.Type) -> Bool // user: %126
20:27:32      %126 = apply %125(%124) : $@convention(method) (@thick Int8.Type) -> Bool // user: %127
20:27:32 In function:
20:27:32 // BuildDB.init(path:clientSchemaVersion:)

@varungandhi-apple
Copy link
Contributor

varungandhi-apple commented Jun 17, 2021

That issue is due to arm64e/arm64 mixup. There's a PR with a workaround #37961 .

@xedin
Copy link
Contributor Author

xedin commented Jun 22, 2021

@swift-ci test Apple Silicon macOS platform

3 similar comments
@xedin
Copy link
Contributor Author

xedin commented Jun 22, 2021

@swift-ci test Apple Silicon macOS platform

@xedin
Copy link
Contributor Author

xedin commented Jun 28, 2021

@swift-ci test Apple Silicon macOS platform

@xedin
Copy link
Contributor Author

xedin commented Jun 30, 2021

@swift-ci test Apple Silicon macOS platform

@xedin
Copy link
Contributor Author

xedin commented Jun 30, 2021

@swift-ci please test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test-only changes are fine, thanks!

@xedin xedin merged commit 901fd93 into swiftlang:release/5.5 Jul 1, 2021
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.5 labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants