ModuleInterface: sanitize arch when interface file name and encoded flags disagree #37961
Conversation
nkcsgexi
changed the title
|
@swift-ci please test |
nkcsgexi
force-pushed
the
sanitize-when-disagree
branch
from
797bf9e to
98f7446
Compare
|
Build failed |
…lags disagree It's a known issue that we are using arm64e interfaces contents for the arm64 target, meaning the encoded module flags are specifying -target arm64e-x-x instead of -target arm64-x-x. Fortunately, we can tell the target arch from the interface file name, so we could sanitize the target to use by inferring arch from the file name.
nkcsgexi
force-pushed
the
sanitize-when-disagree
branch
from
98f7446 to
49c64cf
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci Please smoke test OS X platform |
|
@swift-ci test new Xcode |
|
Build failed |
|
Build failed |
|
Build failed |
|
Build failed |
|
Build failed |
|
Approved based on the fact that this work for me on my local machine when building with Xcode 13.0 beta 1 -- cannot vouch for any other aspect of this PR |
|
@swift-ci please smoke test macOS |
|
@shahmishal Please notice the macOS tests failed for mysterious reasons. |
nkcsgexi
changed the title
|
Build failed |
|
Build failed |
|
Build failed |
|
Build failed |
|
Build failed |
|
Build failed |
|
Build failed |
|
Build failed |
|
Build failed |
|
Build failed |
|
Build failed |
|
Build failed |
|
Build failed |
|
Build failed |
|
Build failed |
|
Build failed |
|
Build failed |
|
Build failed |
It's a known issue that we are using arm64e interfaces contents for the arm64 target,
meaning the encoded module flags are specifying -target arm64e-x-x instead of
-target arm64-x-x. Fortunately, we can tell the target arch from the interface file
name, so we could sanitize the target to use by inferring arch from the file name.