[SymbolGraph] rename symbol graph files for cross-import overlays #38039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://79474927
|
@swift-ci Please smoke test |
bitjammer
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://79474927
Currently, when generating a symbol graph for a cross-import overlay, the filename is fixed based on the declaring and bystander modules. However, this pattern falls flat when the overlay module contains extensions to other modules' symbols. Since extension graphs are emitted after the main graph, but still get emitted with the same name as the base graph, this would cause the base graph's symbols to be overwritten with the extension symbols.
This PR changes how cross-import overlay modules' symbol graph file names are generated. Now, the main module's name is used all the time, but the symbols it exports are treated as "extensions" of the declaring module in terms of the file naming convention. To prevent a clash with symbols that extend the declaring module, they are merged into the main graph of the overlay.