Skip to content

[5.5] [SymbolGraph] rename symbol graph files for cross-import overlays #38040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

QuietMisdreavus
Copy link
Contributor

Resolves rdar://79474927

This PR cherry-picks #38039 onto release/5.5.

Change Information

  • Explanation: When generating symbol graphs with swift-symbolgraph-extract for a module which declares a cross-import overlay, the file name of the overlay's symbol graphs is changed to accommodate its extensions of other modules' symbols.
  • Scope of Issue: Currently, when generating symbol graphs for cross-import overlays, any extensions in the overlay will emit a symbol graph with the same name, overwriting the base symbol graph and losing information for those symbols.
  • Risk: Low.
  • Automated Testing: The existing lit test, "SymbolGraph/Module/CrossImport", has been updated to exercise this change.

@QuietMisdreavus QuietMisdreavus requested a review from a team as a code owner June 22, 2021 23:31
@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please build toolchain macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - e6f5c42

@QuietMisdreavus
Copy link
Contributor Author

CI was failing for a known issue (rdar://79641780), but the test was disabled. Let's try again...

@swift-ci Please test macOS platform

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please build toolchain macOS platform

@QuietMisdreavus
Copy link
Contributor Author

Now that i look at the disabling PRs, i think i missed the 5.5 one by a minute. Let me restart those builds to make sure.

@swift-ci Please test macOS platform

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please build toolchain macOS platform

4 similar comments
@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please build toolchain macOS platform

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please build toolchain macOS platform

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please build toolchain macOS platform

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please build toolchain macOS platform

@QuietMisdreavus QuietMisdreavus merged commit fd4d619 into release/5.5 Jun 30, 2021
@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus/5.5/overlay-symbol-extensions branch June 30, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants