Skip to content

[Demangler] Fix the name of float vector types in OldDemangler. #38079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

al45tair
Copy link
Contributor

The OldDemangler was still spelling Builtin.Vec4xFPIEEE16 as Builtin.Vec4xFloat16, which meant that feeding its output to the new Remangler caused it to fail with "fatal error: unexpected builtin vector type".

rdar://63485806

The OldDemangler was still spelling Builtin.Vec4xFPIEEE16 as
Builtin.Vec4xFloat16, which meant that feeding its output to the new
Remangler caused it to fail with "fatal error: unexpected builtin
vector type".

rdar://63485806
@al45tair al45tair requested a review from jckarter June 24, 2021 14:12
@al45tair
Copy link
Contributor Author

@swift-ci Please smoke test

Copy link
Contributor

@jckarter jckarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@al45tair al45tair merged commit 8078cc0 into swiftlang:main Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants